lkml.org 
[lkml]   [2015]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values
On 03/08/2015 10:54 AM, Mike Krinkin wrote:
> The %*ph specifier allows to pass a pointer and length instead of
> pushing each byte via stack. The patch converts code to use it.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>

Why not use %pM as long as you are changing this code? It will format the
results in a better way.

Larry

> ---
> drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 122e9b3..960a7a5 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
> memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
> }
> RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> - eeprom->mac_addr[0], eeprom->mac_addr[1],
> - eeprom->mac_addr[2], eeprom->mac_addr[3],
> - eeprom->mac_addr[4], eeprom->mac_addr[5]));
> + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> + eeprom->mac_addr));
> }
>
> static void
>



\
 
 \ /
  Last update: 2015-03-08 17:41    [W:0.068 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site