Messages in this thread | | | Date | Sat, 7 Mar 2015 17:33:55 -0700 | From | Jens Axboe <> | Subject | Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization |
| |
On 03/07/2015 05:24 PM, David Rientjes wrote: > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > initialize it to 0.
You should add it to mempool instead, avoid having this issue show up for other folks as well. It'd be trivial to do. Normal ->alloc() should honor __GFP_ZERO, just do the same manually for removing an item from the internal pool.
-- Jens Axboe
| |