lkml.org 
[lkml]   [2015]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] block, drbd: fix drbd_req_new() initialization
On 03/07/2015 05:24 PM, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
>
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.

You should add it to mempool instead, avoid having this issue show up
for other folks as well. It'd be trivial to do. Normal ->alloc() should
honor __GFP_ZERO, just do the same manually for removing an item from
the internal pool.

--
Jens Axboe



\
 
 \ /
  Last update: 2015-03-08 01:41    [W:0.684 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site