Messages in this thread | | | Date | Fri, 6 Mar 2015 12:04:16 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: kempld-core: Fix callback return value check |
| |
On Thu, 26 Feb 2015, Ameya Palande wrote:
> On success, callback function returns 0. So invert the if condition > check so that we can break out of loop. > > Cc: stable@vger.kernel.org > Signed-off-by: Ameya Palande <2ameya@gmail.com> > --- > drivers/mfd/kempld-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c > index f38ec42..5615522 100644 > --- a/drivers/mfd/kempld-core.c > +++ b/drivers/mfd/kempld-core.c > @@ -739,7 +739,7 @@ static int __init kempld_init(void) > for (id = kempld_dmi_table; > id->matches[0].slot != DMI_NONE; id++) > if (strstr(id->ident, force_device_id)) > - if (id->callback && id->callback(id)) > + if (id->callback && !id->callback(id)) > break; > if (id->matches[0].slot == DMI_NONE) > return -ENODEV;
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |