Messages in this thread | | | Subject | Re: [PATCH v4 4/9] power: reset: Add AT91RM9200 reset driver | From | Paul Bolle <> | Date | Thu, 05 Mar 2015 20:49:14 +0100 |
| |
On Thu, 2015-03-05 at 16:49 +0100, Alexandre Belloni wrote: > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -30,6 +30,13 @@ config POWER_RESET_AT91_RESET > This driver supports restart for Atmel AT91SAM9 and SAMA5 > SoCs > > +config POWER_RESET_AT91RM9200_RESET > + bool "Atmel AT91RM9200 reset driver"
This adds a bool symbol.
> + depends on ARCH_AT91 && MFD_SYSCON > + default SOC_AT91RM9200 > + help > + This driver supports restart for Atmel AT91RM9200. > + > config POWER_RESET_AXXIA > bool "LSI Axxia reset driver" > depends on ARCH_AXXIA > diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile > index 11de15bae52e..96e972bbb922 100644 > --- a/drivers/power/reset/Makefile > +++ b/drivers/power/reset/Makefile > @@ -1,6 +1,7 @@ > obj-$(CONFIG_POWER_RESET_AS3722) += as3722-poweroff.o > obj-$(CONFIG_POWER_RESET_AT91_POWEROFF) += at91-poweroff.o > obj-$(CONFIG_POWER_RESET_AT91_RESET) += at91-reset.o > +obj-$(CONFIG_POWER_RESET_AT91RM9200_RESET) += at91rm9200-reset.o
This objectfile will never be modular.
> obj-$(CONFIG_POWER_RESET_AXXIA) += axxia-reset.o > obj-$(CONFIG_POWER_RESET_BRCMSTB) += brcmstb-reboot.o > obj-$(CONFIG_POWER_RESET_GPIO) += gpio-poweroff.o > diff --git a/drivers/power/reset/at91rm9200-reset.c b/drivers/power/reset/at91rm9200-reset.c > new file mode 100644 > index 000000000000..b739ac82b9c9 > --- /dev/null > +++ b/drivers/power/reset/at91rm9200-reset.c > @@ -0,0 +1,72 @@
> +#include <linux/module.h>
Is this needed?
> +static struct platform_driver at91rm9200_reset_driver = { > + .probe = at91rm9200_reset_probe, > + .driver = { > + .name = "at91rm9200-reset", > + .of_match_table = at91rm9200_reset_of_match, > + }, > +}; > +module_platform_driver(at91rm9200_reset_driver);
This should, perhaps, be replaced by a wrapper that calls platform_driver_register(at91rm9200_reset_driver)
while that wrapper is, well, called through device_initcall()
or something similar. I didn't test this suggestion.
> +MODULE_ALIAS("platform:at91rm9200-reset"); > +MODULE_AUTHOR("Alexandre Belloni <alexandre.belloni@free-electrons.com>"); > +MODULE_DESCRIPTION("Atmel at91rm9200 System Timer Reset driver"); > +MODULE_LICENSE("GPL v2");
All these macros will be, basically, preprocessed away.
Paul Bolle
| |