lkml.org 
[lkml]   [2015]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state
    On 03/04/2015 09:14 PM, Frederic Weisbecker wrote:
    > Current context tracking symbols are designed to express living state.
    > As such they are prefixed with "IN_": IN_USER, IN_KERNEL.
    >
    > Now we are going to use these symbols to also express state transitions
    > such as context_tracking_enter(IN_USER) or context_tracking_exit(IN_USER).
    > But while the "IN_" prefix works well to express entering a context, it's
    > confusing to depict a context exit: context_tracking_exit(IN_USER)
    > could mean two things:
    > 1) We are exiting the current context to enter user context.
    > 2) We are exiting the user context
    > We want 2) but the reviewer may be confused and understand 1)
    >
    > So lets disambiguate these symbols and rename them to CONTEXT_USER and
    > CONTEXT_KERNEL.
    >
    > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    > Cc: Andy Lutomirski <luto@amacapital.net>
    > Cc: Will deacon <will.deacon@arm.com>
    > Cc: Marcelo Tosatti <mtosatti@redhat.com>
    > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    > Cc: Luiz Capitulino <lcapitulino@redhat.com>
    > Cc: Paolo Bonzini <pbonzini@redhat.com>
    > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

    Acked-by: Rik van Riel <riel@redhat.com>



    \
     
     \ /
      Last update: 2015-03-05 17:41    [W:3.400 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site