lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 00/18] ARM: msm multiplatform support
Date
On Wednesday 04 March 2015 21:31:32 Paul Bolle wrote:
> Arnd Bergmann schreef op wo 04-03-2015 om 20:32 [+0100]:
> > arch/arm/mach-msm/board-sapphire.c | 17 +-
>
> Please be aware that board-sapphire.c isn't actually wired into the
> build system _at all_. It never has been (see
> https://lkml.org/lkml/2014/5/14/634 ). There's another thread were the
> submitter of this file basically refuses to remove this file, if memory
> serves me right.
>
> I try not to use colorful language on the net. Perhaps I wouldn't have
> to bother you now if I would have used such language last year.

I noticed this, but since it was not standing in the way of what I tried
to do, I did not do anything about it here.

> You touch board-sapphire.c in 12/18 and 17/18. That was a waste of your
> time, however small. Should I submit a separate patch to remove it or do
> you prefer to fold such a patch into this series?

The patch would be appreciated, but I'd keep it separate from this series.
I saw a lot of things in need of cleanup in the files I touched here,
but refused the temptation, in order to get something done and not
start something controversial.

Arnd


\
 
 \ /
  Last update: 2015-03-04 21:41    [W:0.307 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site