Messages in this thread | | | Date | Wed, 4 Mar 2015 10:56:02 -0800 | Subject | Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly | From | Yinghai Lu <> |
| |
On Wed, Mar 4, 2015 at 10:06 AM, Yinghai Lu <yinghai@kernel.org> wrote: > On Wed, Mar 4, 2015 at 2:16 AM, Borislav Petkov <bp@alien8.de> wrote: >> On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote: >>> commit f47233c2d34f ("x86/mm/ASLR: Propagate base load address calculation") >>> is using address as value for kaslr_enabled. >>> >>> That will random kaslr_enabled get that set or cleared. >>> Will have problem for system really have kaslr enabled. >>> >>> -v2: update changelog. >> >> This is still not good enough. Please do this: >> >> In commit f47233c2d34f we did A. The problem with that is B. Change the >> code to do C. >> >> Now you only have to fill out the A,B and C variables with the >> respective text which is understandable even for people who don't know >> this code.
Please check if it is ok:
Subject: [PATCH v3] x86, kaslr: get kaslr_enabled back correctly
commit f47233c2d34f ("x86/mm/ASLR: Propagate base load address calculation") is using address as value for kaslr_enabled.
That will get wrong value for kaslr_enabled, so have problem for system really have kaslr enabled.
This patch change to using early map and accessing the value.
-v3: add checking about early_memmap according to bp.
| |