Messages in this thread | | | Date | Tue, 31 Mar 2015 23:45:13 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86, earlyprintk: Fix two 'defined but not used' compile warnings |
| |
On Tue, Mar 31, 2015 at 10:20:12PM +0100, Mark Einon wrote: > Two static functions are only used if CONFIG_PCI is defined,so only build them > if this is the case. Fixes the build warnings: > > arch/x86/kernel/early_printk.c:98:13: warning: ‘mem32_serial_out’ defined but not used [-Wunused-function] > static void mem32_serial_out(unsigned long addr, int offset, int value) > ^ > arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but not used [-Wunused-function] > static unsigned int mem32_serial_in(unsigned long addr, int offset) > ^ > Signed-off-by: Mark Einon <mark.einon@gmail.com> > --- > arch/x86/kernel/early_printk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c > index f85e3fb..6a69625 100644 > --- a/arch/x86/kernel/early_printk.c > +++ b/arch/x86/kernel/early_printk.c > @@ -95,6 +95,7 @@ static unsigned long early_serial_base = 0x3f8; /* ttyS0 */ > #define DLL 0 /* Divisor Latch Low */ > #define DLH 1 /* Divisor latch High */ > > +#ifdef CONFIG_PCI > static void mem32_serial_out(unsigned long addr, int offset, int value) > { > uint32_t *vaddr = (uint32_t *)addr; > @@ -108,6 +109,7 @@ static unsigned int mem32_serial_in(unsigned long addr, int offset) > /* shift implied by pointer type */ > return readl(vaddr + offset); > } > +#endif
I'm sceptical we ever build x86 with CONFIG_PCI disabled but whatever.
Instead of adding another #ifdef CONFIG_PCI, please move those two functions right over early_pci_serial_init() inside the #ifdef CONFIG_PCI there.
Thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |