lkml.org 
[lkml]   [2015]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 019/143] HID: fixup the conflicting keyboard mappings quirk
    Date
    3.13.11-ckt18 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Kosina <jkosina@suse.cz>

    commit 8e7b341037db1835ee6eea64663013cbfcf33575 upstream.

    The ignore check that got added in 6ce901eb61 ("HID: input: fix confusion
    on conflicting mappings") needs to properly check for VARIABLE reports
    as well (ARRAY reports should be ignored), otherwise legitimate keyboards
    might break.

    Fixes: 6ce901eb61 ("HID: input: fix confusion on conflicting mappings")
    Reported-by: Fredrik Hallenberg <megahallon@gmail.com>
    Reported-by: David Herrmann <dh.herrmann@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/hid/hid-input.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
    index a8382fa..bd6a436 100644
    --- a/drivers/hid/hid-input.c
    +++ b/drivers/hid/hid-input.c
    @@ -1075,6 +1075,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
    */
    if (!(field->flags & (HID_MAIN_ITEM_RELATIVE |
    HID_MAIN_ITEM_BUFFERED_BYTE)) &&
    + (field->flags & HID_MAIN_ITEM_VARIABLE) &&
    usage->usage_index < field->maxusage &&
    value == field->value[usage->usage_index])
    return;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-03-31 23:01    [W:3.252 / U:0.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site