Messages in this thread | | | Subject | Re: [PATCH 1/7] lib/vsprintf: add %*pg format specifier | From | Joe Perches <> | Date | Tue, 31 Mar 2015 10:37:14 -0700 |
| |
On Tue, 2015-03-31 at 10:06 -0700, Joe Perches wrote: > On Tue, 2015-03-31 at 20:01 +0400, Dmitry Monakhov wrote: > > This allow to directly print block_device name. > > Currently one should use bdevname() with temporal char buf[BDEVNAME_SIZE]. > > This is very ineffective because bloat stack usage for deep IO call-traces
Perhaps it would be useful to update the disk_name/bdevname functions to take a buffer length along with the char * so that buffer overflows could not occur.
That would also allow this function to use bdevname directly.
| |