lkml.org 
[lkml]   [2015]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] kselftests: timers: Make set-timer-lat fail more gracefully for !CAP_WAKE_ALARM
    Hi John,

    I am seeing checkpatch warnings on this patch. See below.

    On 03/26/2015 05:31 AM, Prarit Bhargava wrote:
    >
    >
    > On 03/25/2015 07:44 PM, John Stultz wrote:
    >> The set-timer-lat test fails when testing CLOCK_BOOTTIME_ALARM
    >> or CLOCK_REALTIME_ALARM when the user isn't running as root or
    >> with CAP_WAKE_ALARM.
    >>
    >> So this patch improves the error checking so we report the
    >> issue more clearly and continue rather then reporting a failure.
    >>
    >> Cc: Shuah Khan <shuahkh@osg.samsung.com>
    >> Cc: Prarit Bhargava <prarit@redhat.com>
    >> Cc: Thomas Gleixner <tglx@linutronix.de>
    >> Cc: Richard Cochran <richardcochran@gmail.com>
    >> Signed-off-by: John Stultz <john.stultz@linaro.org>
    >> Signed-off-by: John Stultz <john.stultz@linaro.org>

    WARNING: Duplicate signature
    #115:
    Signed-off-by: John Stultz <john.stultz@linaro.org>

    >> ---
    >> tools/testing/selftests/timers/set-timer-lat.c | 7 +++++++
    >> 1 file changed, 7 insertions(+)
    >>
    >> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
    >> index 3ea2eff..dbc9537c 100644
    >> --- a/tools/testing/selftests/timers/set-timer-lat.c
    >> +++ b/tools/testing/selftests/timers/set-timer-lat.c
    >> @@ -139,6 +139,13 @@ int do_timer(int clock_id, int flags)
    >>
    >> err = timer_create(clock_id, &se, &tm1);
    >> if (err) {
    >> + if ((clock_id == CLOCK_REALTIME_ALARM)
    >> + || (clock_id == CLOCK_BOOTTIME_ALARM)) {
    >
    > I dunno of there is actually a CodingStyle rule for this, but I've always seen
    > this written with the operator on the first line:

    Yes it would be good to fix this one as well when you re-do the patch.


    >
    > if ((clock_id == CLOCK_REALTIME_ALARM) ||
    > (clock_id == CLOCK_BOOTTIME_ALARM)) {
    >
    >> + printf("%-22s %s missing CAP_WAKE_ALARM? : [UNSUPPORTED]\n",
    >> + clockstring(clock_id),
    >> + flags ? "ABSTIME":"RELTIME");
    >

    WARNING: line over 80 characters
    #130: FILE: tools/testing/selftests/timers/set-timer-lat.c:144:
    + printf("%-22s %s missing CAP_WAKE_ALARM? : [UNSUPPORTED]\n",

    thanks,
    -- Shuah

    --
    Shuah Khan
    Sr. Linux Kernel Developer
    Open Source Innovation Group
    Samsung Research America (Silicon Valley)
    shuahkh@osg.samsung.com | (970) 217-8978


    \
     
     \ /
      Last update: 2015-03-31 18:21    [W:2.783 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site