Messages in this thread | | | Date | Tue, 31 Mar 2015 08:49:39 +0200 | Subject | Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410 | From | Javier Martinez Canillas <> |
| |
Hello Alexandre,
On Tue, Mar 31, 2015 at 2:27 AM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c >
Yes but Krzysztof is following the convention used in drivers/rtc/ which I think is the correct thing to do even when it's different from what is used all over the kernel.
> On 30/03/2015 at 17:19:32 +0200, Krzysztof Kozlowski wrote : >> There are now no differences between RTC on Exynos3250 and S3C6410. >> Merge everything into one so duplicated code could be removed. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> >
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards, Javier
| |