lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410
On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote:
> There are now no differences between RTC on Exynos3250 and S3C6410.
> Merge everything into one so duplicated code could be removed.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index fb0c569765c6..5e162eaad277 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -774,18 +774,6 @@ static struct s3c_rtc_data const s3c6410_rtc_data = {
> .disable = s3c6410_rtc_disable,
> };
>
> -static struct s3c_rtc_data const exynos3250_rtc_data = {
> - .max_user_freq = 32768,
> - .needs_src_clk = true,
> - .irq_handler = s3c6410_rtc_irq,
> - .set_freq = s3c6410_rtc_setfreq,
> - .enable_tick = s3c6410_rtc_enable_tick,
> - .save_tick_cnt = s3c6410_rtc_save_tick_cnt,
> - .restore_tick_cnt = s3c6410_rtc_restore_tick_cnt,
> - .enable = s3c24xx_rtc_enable,
> - .disable = s3c6410_rtc_disable,
> -};
> -
> static const struct of_device_id s3c_rtc_dt_match[] = {
> {
> .compatible = "samsung,s3c2410-rtc",
> @@ -801,7 +789,7 @@ static const struct of_device_id s3c_rtc_dt_match[] = {
> .data = (void *)&s3c6410_rtc_data,
> }, {
> .compatible = "samsung,exynos3250-rtc",
> - .data = (void *)&exynos3250_rtc_data,
> + .data = (void *)&s3c6410_rtc_data,
> },
> { /* sentinel */ },
> };
>

Looks good to me.

Reviewd-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi


\
 
 \ /
  Last update: 2015-03-31 02:01    [W:0.310 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site