Messages in this thread | | | Date | Mon, 30 Mar 2015 17:38:45 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 03/17] x86, mpx: trace #BR exceptions |
| |
On Mon, 30 Mar 2015 14:33:30 -0700 Dave Hansen <dave@sr71.net> wrote:
> On 03/30/2015 02:25 PM, Steven Rostedt wrote: > ... > >> > +#ifdef CONFIG_X86_INTEL_MPX
I missed this #ifdef
> >> > + > >> > +TRACE_EVENT(bounds_exception_mpx, > ... > >> > + TP_printk("bndcfgu:0x%llx bndstatus:0x%llx", > >> > + __entry->bndcfgu, > >> > + __entry->bndstatus) > >> > +); > >> > + > >> > +#else > >> > + > >> > +/* > >> > + * This gets used outside of MPX-specific code, so we need a stub. > >> > + */ > > I'm a bit confused by this. What exactly is used outside of MPX-specific code? > > Does it break the build without this? > > It gets used in arch/x86/kernel/traps.c. There's a point when we've > decided that the #BR exception is an MPX-specific one and that's where > we'd like the tracepoint to be. > > Yes, it breaks the build without this.
Thanks for the explanation.
-- Steve
| |