lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/17] x86, mpx: trace #BR exceptions
    On Mon, 30 Mar 2015 14:33:30 -0700
    Dave Hansen <dave@sr71.net> wrote:

    > On 03/30/2015 02:25 PM, Steven Rostedt wrote:
    > ...
    > >> > +#ifdef CONFIG_X86_INTEL_MPX

    I missed this #ifdef

    > >> > +
    > >> > +TRACE_EVENT(bounds_exception_mpx,
    > ...
    > >> > + TP_printk("bndcfgu:0x%llx bndstatus:0x%llx",
    > >> > + __entry->bndcfgu,
    > >> > + __entry->bndstatus)
    > >> > +);
    > >> > +
    > >> > +#else
    > >> > +
    > >> > +/*
    > >> > + * This gets used outside of MPX-specific code, so we need a stub.
    > >> > + */
    > > I'm a bit confused by this. What exactly is used outside of MPX-specific code?
    > > Does it break the build without this?
    >
    > It gets used in arch/x86/kernel/traps.c. There's a point when we've
    > decided that the #BR exception is an MPX-specific one and that's where
    > we'd like the tracepoint to be.
    >
    > Yes, it breaks the build without this.

    Thanks for the explanation.

    -- Steve



    \
     
     \ /
      Last update: 2015-03-31 00:21    [W:2.094 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site