lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] mac80211: Use #define IEEE80211_CCMP_PN_LEN and bool
From
Date
On Mon, 2015-03-30 at 22:01 +0200, Johannes Berg wrote:
> On Mon, 2015-03-30 at 09:37 -0700, Joe Perches wrote:
>
> > @@ -89,11 +90,11 @@ struct ieee80211_fragment_entry {
> > unsigned int last_frag;
> > unsigned int extra_len;
> > struct sk_buff_head skb_list;
> > - int ccmp; /* Whether fragments were encrypted with CCMP */
> > - u8 last_pn[6]; /* PN of the last fragment if CCMP was used */
> > + /* for CCMP fragments */
> > + bool ccmp; /* encrypted with CCMP */
> > + u8 last_pn[IEEE80211_CCMP_PN_LEN]; /* PN of the last fragment */
>
> I took your patch as an opportunity to check into this, and it turns out
> all of this logic is also going to be needed for GCMP. As a result, I'm
> not going to take this patch but instead we'll fix it up for GCMP (where
> using CCMP_PN_LEN would not be appropriate anyway - perhaps we need a
> union or just keep '8' which is the right size for both anyway, or we'll
> go to a u64 value or something)

No worries. Whatever's right.




\
 
 \ /
  Last update: 2015-03-30 22:41    [W:0.083 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site