Messages in this thread | | | Date | Sun, 29 Mar 2015 21:56:32 -0700 | Subject | Re: [PATCH 1/2] Input: Add binding document for a generic ADC keypad | From | Andrew Bresticker <> |
| |
On Sat, Mar 28, 2015 at 9:00 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Fri, Mar 27, 2015 at 05:43:17PM -0700, Andrew Bresticker wrote: >> Add a binding document for a generic ADC keypad. Buttons on an ADC >> keypad are connected in a resistor ladder to an ADC. The binding >> describes the mapping of ADC channel and voltage ranges to buttons. >> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Pawel Moll <pawel.moll@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >> Cc: Kumar Gala <galak@codeaurora.org> >> --- >> .../devicetree/bindings/input/adc-keys.txt | 43 ++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt >> >> diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt >> new file mode 100644 >> index 0000000..c9a57de >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/adc-keys.txt >> @@ -0,0 +1,43 @@ >> +Generic ADC keypad >> +================== >> + >> +Required properties: >> + - compatible: "adc-keys" >> + - poll-interval: Polling interval time in ms. >> + - io-channels: List of IIO channels used by the keypad. >> + See ../iio/iio-bindings.txt for details. >> + >> +Optional properties: >> + - autorepeat: Enable auto-repeat. >> + >> +Each button on the ADC keypad is represented by a sub-node. >> + >> +Required sub-node properties: >> + - label: Descriptive name for the key. >> + - linux,code: Keycode to emit. >> + - channel: IIO channel (index into the 'io-channels' above) to which this >> + button is attached. >> + - min-voltage: Minimum voltage in uV when this key is pressed. >> + - max-voltage: Maximum voltage in uV when this key is pressed. >> + >> +Optional sub-node properties: >> + - linux,input-type: Event type this key generates. Defaults to 1 (EV_KEY) if >> + not specified. > > I'd rather we have it defined explicitly in the binding, i.e. make it a > required property?
Sure, will do.
| |