lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Fix kernel crash in cipso_v4_sock_delattr ]
On 3/30/2015 4:32 AM, Paul Moore wrote:
> On Monday, March 30, 2015 11:09:00 AM Maninder Singh wrote:
>> Dear All,
>> we found One Kernel Crash issue in cipso_v4_sock_delattr :-
>> As Cipso supports only inet sockets so cipso_v4_sock_delattr will crash when
>> try to access any other socket type. cipso_v4_sock_delattr access
>> sk_inet->inet_opt which may contain not NULL but invalid address. we found
>> this issue with netlink socket.(reproducible by trinity using sendto system
>> call .)
> Hello,
>
> First, please go read the Documentation/SubmittingPatches from the kernel
> sources; your patch needs to be resubmitted and the instructions in that file
> will show you how to do it correctly next time.
>
> Second, this appears to only affect Smack based systems, yes? SELinux based
> systems should have the proper checking in place to prevent this (the checks
> are handled in the LSM).

This looks like a problem that was fixed some time ago.
The current Smack code clearly checks for this. What kernel
version are you testing against?

> That said, it probably wouldn't hurt to add the
> extra checking to netlbl_sock_delattr(). If you properly resubmit your patch
> I'll ACK it.
>
> -Paul
>



\
 
 \ /
  Last update: 2015-03-30 20:01    [W:1.529 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site