Messages in this thread | | | Date | Mon, 30 Mar 2015 12:08:43 -0500 | From | Alex Elder <> | Subject | Re: [PATCH] debugfs: allow bad parent pointers to be passed in |
| |
On 03/30/2015 07:59 AM, Greg KH wrote: > If something went wrong with creating a debugfs file/symlink/directory, > that value could be passed down into debugfs again as a parent dentry. > To make caller code simpler, just error out if this happens, and don't > crash the kernel. > > Reported-by: Alex Elder <elder@linaro.org> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> > --- > fs/debugfs/inode.c | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/fs/debugfs/inode.c > +++ b/fs/debugfs/inode.c > @@ -254,6 +254,9 @@ static struct dentry *start_creating(con > > pr_debug("debugfs: creating file '%s'\n",name); > > + if (IS_ERR(parent)) > + return parent; > + > error = simple_pin_fs(&debug_fs_type, &debugfs_mount, > &debugfs_mount_count); > if (error) >
| |