lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] [SMB3] Fix warning on uninitialized buftype
    From
    Date
    On Fri, 2015-03-27 at 00:27 -0500, Steve French wrote:
    > Pointed out by coverity analyzer. resp_buftype is
    > not initialized in one path which can rarely log
    > a spurious warning (buf is null so there will
    > not be a problem with freeing data, but if buf_type
    > were randomly set to wrong value could log a warning)
    >
    > Reported by Coverity (CID 1269144)
    >
    > Signed-off-by: Steve French <smfrench@gmail.com>

    ACKed-by: Sachin Prabhu <sprabhu@redhat.com>

    > ---
    > fs/cifs/smb2pdu.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
    > index 3417340..1b906de 100644
    > --- a/fs/cifs/smb2pdu.c
    > +++ b/fs/cifs/smb2pdu.c
    > @@ -2114,7 +2114,7 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon,
    > struct kvec iov[2];
    > int rc = 0;
    > int len;
    > - int resp_buftype;
    > + int resp_buftype = CIFS_NO_BUFFER;
    > unsigned char *bufptr;
    > struct TCP_Server_Info *server;
    > struct cifs_ses *ses = tcon->ses;




    \
     
     \ /
      Last update: 2015-03-30 12:01    [W:4.019 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site