Messages in this thread | | | Date | Mon, 30 Mar 2015 10:59:00 +0200 | Subject | Re: [PATCH 2/3] leds/class: Check snprintf return value | From | Geert Uytterhoeven <> |
| |
On Mon, Mar 30, 2015 at 10:55 AM, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -223,12 +223,17 @@ static int led_classdev_next_name(const char *init_name, char *name, > size_t len) > { > int i = 0; > + int ret = 0; > > strlcpy(name, init_name, len); > > - while (class_find_device(leds_class, NULL, name, match_name)) > + while (class_find_device(leds_class, NULL, name, match_name) && > + (ret < len)) > snprintf(name, len, "%s_%d", init_name, ++i);
Missing "ret = "
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |