lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] leds/class: Use strlcpy instead of strncpy
    Date
    Strncpy does not guarantee a zero terminated string. Use strlcpy
    instead.

    Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
    ---
    drivers/leds/led-class.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
    index ebf6dad4f..294d6d6 100644
    --- a/drivers/leds/led-class.c
    +++ b/drivers/leds/led-class.c
    @@ -224,7 +224,7 @@ static int led_classdev_next_name(const char *init_name, char *name,
    {
    int i = 0;

    - strncpy(name, init_name, len);
    + strlcpy(name, init_name, len);

    while (class_find_device(leds_class, NULL, name, match_name))
    snprintf(name, len, "%s_%d", init_name, ++i);
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-03-30 11:21    [W:4.317 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site