lkml.org 
[lkml]   [2015]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code
From
From: Joe Perches <joe@perches.com>
Date: Tue, 03 Mar 2015 11:07:51 -0800

> On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote:
>> On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote:
>>
>> > At least for arm gcc 4.6.3, it emits different code
>> > for net/l2tp/l2tp_eth.o
>>
>> Then it looks like arm gcc or arm linux memset() should be improved.
>
> Perhaps you can take that up with the gcc folk.
>
> I think it appropriate to improve the actual emitted
> code for the compiler I use.

In the long term, this is poor time spent. If you fixed GCC
everyone would benefit in the world, not just kernel builders.

Furthermore, none of this crap is in the fast path of anything.

I'm not applying this series, it's basis is not well founded
yet you keep trying to argue otherwise.


\
 
 \ /
  Last update: 2015-03-03 20:41    [W:0.087 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site