Messages in this thread | | | Date | Tue, 03 Mar 2015 14:23:31 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH 1/2] x86/regsets: change xstateregs_get/set to use ->xsave.i387 rather than ->fxsave |
| |
On 03/02/2015 01:32 PM, Oleg Nesterov wrote: > Cosmetic. xstateregs_get() and xstateregs_set() abuse ->fxsave to access > xsave->i387.sw_reserved. This is correct, ->fxsave and xsave->i387 share > the same memory, but imho this looks confusing. > > And we can make this code more readable if we add "struct xsave_struct *" > local. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
-- All rights reversed
| |