Messages in this thread | | | Date | Tue, 3 Mar 2015 20:59:18 +0530 | Subject | Re: [PATCH v3 5/5] thermal: cpu_cooling: update the cpu device when cpufreq updates the policy cpu | From | Viresh Kumar <> |
| |
On 3 March 2015 at 20:39, Kapileshwar Singh <kapileshwar.singh@arm.com> wrote:
> I did test this but we were working with the assumption that OPPs should be populated for all the CPUs and also that OPPs are lost for a hotplugged CPU which I see is not the case.
Then what did you test? My point here is, even with the latest patches that you have sent, you wouldn't be able to get the OPPs once policy->cpu goes down. So, how did this worked for you ?
> We have looked at this more closely and found that problem lies in: > > freq = cpufreq_quick_get(cpumask_any(&cpufreq_device->allowed_cpus)); > > which returns a NULL frequency as we are not checking for online CPUs here. We shall come up with a fix for this. Many thanks for helping us with the investigation.
Right.
| |