Messages in this thread Patch in this message | | | Date | Tue, 3 Mar 2015 16:07:55 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings |
| |
On Tue, Mar 03, 2015 at 12:54:38PM +0000, Cláudio Maia wrote: > The following errors were fixed: > > ERROR: code indent should use tabs where possible > WARNING: line over 80 characters > > Signed-off-by: Cláudio Maia <crrm@isep.ipp.pt>
Can you resend these but split up differently.
> + write_reg(par, 0x22);/* > + 5:1 1 > + 2:0 PD - Powerdown control: chip is active > + 1:1 V - Entry mode: vertical addressing > + 0:0 H - Extended instruction set control: basic > + */ >
These comments are all kinds of whacky looking. You fix them in the 2/2 patch, but we don't want to have this intermidiate whacky looking patch. Just send them when they look good like in the 2/2 patch.
> @@ -130,7 +133,8 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) > gpio_set_value(par->gpio.dc, 1); > ret = par->fbtftops.write(par, par->txbuf.buf, 6*84); > if (ret < 0) > - dev_err(par->info->device, "%s: write failed and returned: %d\n", __func__, ret); > + dev_err(par->info->device, "%s: write failed and returned: %d\n", > + __func__, ret);
Do these non-comment fixes in a separate patch. In other words:
[patch 1/2] break up a few long lines this patch doesn't touch comments [patch 2/2] make comments look good this is 1/2 and 2/2 comment changes combined
regards, dan carpenter
| |