Messages in this thread | | | Date | Tue, 3 Mar 2015 12:35:54 +0100 | From | Nicholas Mc Guire <> | Subject | Re: [PATCH] ide_tape: convert jiffies with jiffies_to_msecs |
| |
On Tue, 03 Mar 2015, Joe Perches wrote:
> On Tue, 2015-03-03 at 11:57 +0100, Nicholas Mc Guire wrote: > > On Tue, 03 Mar 2015, Joe Perches wrote: > > > On Tue, 2015-03-03 at 05:23 -0500, Nicholas Mc Guire wrote: > > > > Note that this patch will give a checkpatch warning due to "quoted string > > > > split across lines" but thats not related to this change - not sure if this > > > > should be fixed - looks intentional to me. > > > > > > It's not. It'd be better coalesced. > > > > well it did seem quite systematic in this file, aside from it also needing > > to move over the pr_* so thats going to need a few seperate cleanups. > > Sure, no worries, whenever/ifever. > > I'm pretty sure there aren't many active users > of ide-tape devices. > Im sure thats true - the motivation for cleanups though is that what ever stays in old drivers - even if hardly in use- gets copied into new drivers at some point...
thx! hofrat
| |