Messages in this thread | | | Date | Mon, 30 Mar 2015 01:21:02 +0200 | From | Mateusz Kulikowski <> | Subject | Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp() |
| |
Hi Joe,
Thanks for reviewing my patches.
On 30.03.2015 01:13, Joe Perches wrote: > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote: >> Return from rtllib_rx_auth_resp() if auth_parse() fails. > > Hello Mateusz. Here are some trivial notes. > >> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > [] >> + /* Dummy wirless mode setting to avoid >> + * encryption issue */ > > Please use the typical networking comment style > (and correct the typo too) > > /* Dummy wireless mode setting to avoid > * encryption issue > */
It was like that already - is it ok with you if I fix all the comments (in whole rtl8192e) in separate patch (I can add it as #12 to v2) ?
> >> + if (bSupportNmode) { >> + ieee->SetWirelessMode(ieee->dev, >> + ieee->current_network.mode); >> + } else { >> + /*TODO*/ >> + ieee->SetWirelessMode(ieee->dev, >> + IEEE_G); > > Many of these multiple line statements can be single line.
I wanted to split change of logic and re-indentation; If you insist - I can merge patches #10 and #11 (#11 does what you ask for)
Regards, Mateusz
| |