Messages in this thread | | | Date | Sun, 29 Mar 2015 20:17:02 +0200 | From | Richard Weinberger <> | Subject | Re: [RFC PATCH 08/11] lib: other kernel glue layer code |
| |
Am 24.03.2015 um 14:10 schrieb Hajime Tazaki: > These files are used to provide the same function calls so that other > network stack code keeps untouched. > > Signed-off-by: Hajime Tazaki <tazaki@sfc.wide.ad.jp> > Signed-off-by: Christoph Paasch <christoph.paasch@gmail.com> > --- > arch/lib/cred.c | 16 +++ > arch/lib/dcache.c | 93 +++++++++++++++ > arch/lib/filemap.c | 27 +++++ > arch/lib/fs.c | 287 ++++++++++++++++++++++++++++++++++++++++++++ > arch/lib/glue.c | 336 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > arch/lib/inode.c | 146 +++++++++++++++++++++++ > arch/lib/modules.c | 36 ++++++ > arch/lib/pid.c | 29 +++++ > arch/lib/print.c | 56 +++++++++ > arch/lib/proc.c | 164 +++++++++++++++++++++++++ > arch/lib/random.c | 53 +++++++++ > arch/lib/security.c | 45 +++++++ > arch/lib/seq.c | 122 +++++++++++++++++++ > arch/lib/splice.c | 20 ++++ > arch/lib/super.c | 210 ++++++++++++++++++++++++++++++++ > arch/lib/sysfs.c | 83 +++++++++++++ > arch/lib/vmscan.c | 26 ++++ > 17 files changed, 1749 insertions(+)
BTW: Why do you need these stub implementations at all? If I read your code correctly it is because you're linking against the whole net/ directory. Let's take register_filesystem() again as example. net/socket.c references it in sock_init(). Maybe it would make sense to split socket.c into two files, net/socket.c and net/sockfs.c. Such that you could link only net/socket.o. Of course you'd have to convince networking folks first. :D
By linking selectively objects files from net/ you could get rid of a lot unneeded stubs.
Thanks, //richard
| |