Messages in this thread | | | Date | Sat, 28 Mar 2015 13:24:12 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC PATCH] perf tui: Annotate entries in callchains |
| |
Em Fri, Mar 27, 2015 at 04:05:03PM -0700, Stephane Eranian escreveu: > On Mon, Mar 23, 2015 at 9:56 AM, Arnaldo Carvalho de Melo wrote: > > Le 23 mars 2015 13:49:24 GMT-03:00, Stephane Eranian <eranian@google.com> a écrit : > >>On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim <namhyung@kernel.org> > >>> Did you play with acme/perf/core not tip/perf/core? I got same > >>> problem but then I realize it's not the Arnaldo's tree. When I > >>> changed to acme/perf/core the problem disappeared. :)
> >>I was only trying it with tip.git. The patch looke simple enough to > >>apply to tip.git but clearly it relies on some other infrastructure > >>changes which I don't know about. In my case =, I care about getting > >>this feature in tip.git or older versions of perf.
> > It is all in tip.git by now.
> >>> But unfortunately I got this segfault instead..
> > Needs a patch that is in perf/urgent
> If I pull tip.git now. Does it have what is needed to work?
Yes, it should, but you may hit the bug Namhyumg reported, fixed in:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/tools/perf/util/annotate.c?id=3995614d9b0320e10ce202836c8477e1bcf1a2d4
perf annotate: Fix fallback to unparsed disassembler line
----
Humm, by tip.git you mean tip.git/master? /me checks...
[acme@ssdandy linux]$ git log --oneline tip/master tools/perf/util/annotate.c | head -5 571564babaa3 Merge branch 'perf/core' 2c7da8c590ad perf annotate: Allow annotation for decompressed kernel modules <------------------ 3995614d9b03 perf annotate: Fix fallback to unparsed disassembler line 48000a1aed74 perf tools: Remove EOL whitespaces 0fb9f2aab738 perf annotate: Fix memory leaks in LOCK handling [acme@ssdandy linux]$
Yeah, it is there, should have everything you need.
- Arnaldo
| |