Messages in this thread | | | Date | Fri, 27 Mar 2015 16:50:34 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling |
| |
On Tue, Mar 17, 2015 at 03:51:13AM -0400, Nicholas Mc Guire wrote: > wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check > for >= 0 is always true and can be dropped implying that r==-EREMOTEIO and thus > the return of -EREMOTEIO can be done in the if (dev->buf_len) branch. > As wait_for_completion_timeout returns unsigned long not int, and int r is > exclusively used for wait_for_completion_timeout it is renamed and the type > changed to unsigned long. > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Applied to for-next, thanks!
[unhandled content-type:application/pgp-signature] | |