lkml.org 
[lkml]   [2015]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] x86/asm/entry/32: Use PUSH instructions to build pt_regs on stack

* Denys Vlasenko <dvlasenk@redhat.com> wrote:

> On 03/27/2015 12:32 PM, Ingo Molnar wrote:
> >
> > * Denys Vlasenko <dvlasenk@redhat.com> wrote:
> >
> >> This mimics the recent similar 64-bit change.
> >> Saves ~110 bytes of code.
> >
> > Would be nice to know whether you tested all the affected system entry
> > variants, on both AMD and Intel CPUs?
>
> Yes, I did. I also looked at the diff of entry_64.o disassembly, to have
> a different view of the changes.

That kind of information needs to be in the changelog.

> I know how fragile this stuff is.

yeah ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-03-27 14:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog