Messages in this thread | | | Date | Thu, 26 Mar 2015 17:28:01 -0700 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: Add support for NAU8824 codec to ASoC |
| |
On Thu, Mar 26, 2015 at 02:58:53PM -0700, Chih-Chiang Chang wrote: > On 3/6/2015 1:07 PM, Mark Brown wrote: > > On Fri, Mar 06, 2015 at 03:28:33PM +0800, Chih-Chiang Chang wrote:
> > Please fix your mailer to word wrap within paragraphs, it makes things a > > lot easier to read.
> This seems to violate the kernel's rule. I am using the Thunderbird to > do upstream. And in kernel's documentation, it shows we should set > "mailnews.wraplength" from "72" to "0". Any way, for your convenience, I > already modify the "mailnews.wraplength" back to "72".
You should never word wrap code since that corrupts the patches but always word wrap text.
> > I'd really like to have a better understanding of what this is doing - > > it can be valid to do this but there are some warning signs here such as > > the volume of writes being large in comparison with the set of controls > > the driver exposes which mean I'd like to be sure the use matches > > expectations. Normally this sort of thing is a small number of fixes > > for undocumented registers or updates to register defaults changed in > > later revisions of the chip.
> We have tried to reduce the sequence recently, but it got some issues in > the tests. We think these large number of register settings are > necessary to our NAU8824 codec. We will provide the comments of all > values in source to have a better understanding, is it acceptable to you?
It sounds reasonable but obviously I've not seen the results yet. [unhandled content-type:application/pgp-signature] | |