lkml.org 
[lkml]   [2015]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 RESEND 0/2] serial: 8250_pci: Fintek products patches
On Tue, Mar 17, 2015 at 06:02:13PM +0800, Peter Hung wrote:
> These series patches works for Fintek F81504/F81508/F81512 PCI to Serial Port.
> and patch 0002 is following with patch 0001.
>
> patch 0001 is just cleanup non-used source code.
> patch 0002 is major patch.
>
> The serial port of our product will failed after wakeup from S3(STR).
>
> It's due to when the system wakeup from S3(STR), this PCI device's
> configuration space from 0x40 to 0x40 + max_port * 0x08 should be
> re-configured. If had no re-configure, It's will all zero.
>
> We move all initialization from pci_fintek_setup() to pci_fintek_init() and
> set it to pci_serial_quirks struct .init section. It's will re-init this
> device when system wakeup from pciserial_resume_ports().

What changed from version 1?

> Peter Hung (2):
> serial: 8250_pci: remove non-used var for F81504
> serial: 8250_pci: port failed after wakeup from S3
>
> drivers/tty/serial/8250/8250_pci.c | 121 +++++++++++++++----------------------
> 1 file changed, 50 insertions(+), 71 deletions(-)
> mode change 100644 => 100755 drivers/tty/serial/8250/8250_pci.c

You can't change the mode of a kernel file to executable, that's not
allowed, and is a bug somewhere in your editor.

Please fix this up and resend the series, I can't take these as-is.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-03-26 22:41    [W:2.503 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site