lkml.org 
[lkml]   [2015]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer
On Thu, Mar 26, 2015 at 05:58:20PM +0100, Michael Wang wrote:

> The questions is just wondering how the transition method could be, but
> if we have to do the changes for vendor, that sounds like a tough job...

I would see changing how the information is represented in the struct
as a follow on issue. The first patch should go through and replace
all direct access to the link layer/transport/etc with an
appropriately narrow is_XX() test like Doug was suggesting.

That means looking at each code site and determining what it needs,
making a is_XX for it and a kdoc describing exactly what is needed for
the test to return true.

The follow on patch can then rework the is_XX and drop the link
layer/transport stuff..

Some ideas for is_XX:
IB compatible SA
QP0 SMP mechanism
IB SMP format
OPA SMP format
QP1 GMP mechanism
IB compatible CM
GID addressing
IP/IPv6 addressing
Ethernet VLAN
...

Jason


\
 
 \ /
  Last update: 2015-03-26 22:21    [W:0.315 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site