lkml.org 
[lkml]   [2015]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] pmem: Initial version of persistent memory driver
On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote:
> What needed to be fixed with the partition support? I used to have real
> numbers for first_minor and passed into alloc_disk(), but simplified it based
> on code found in this commit in the nvme driver:
>
> 469071a37afc NVMe: Dynamically allocate partition numbers
>
> This has worked fine for me - is there some test case in which it breaks?

Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all.

> > +out_unmap:
> > + pmem_unmapmem(pmem);
> > +out_free_dev:
> > + kfree(pmem);
> > +out:
>
> This label is no longer used, and can be removed.

Ok, fixed.


\
 
 \ /
  Last update: 2015-03-26 09:21    [W:0.214 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site