Messages in this thread | | | Date | Thu, 26 Mar 2015 12:13:12 +0200 | From | Daniel Baluta <> | Subject | Re: [PATCH 1/3] iio: configfs: Add configfs support to IIO |
| |
On 03/25/2015 10:14 PM, Paul Bolle wrote: > A license nit. > > On Wed, 2015-03-25 at 19:00 +0200, Daniel Baluta wrote: >> --- /dev/null >> +++ b/drivers/iio/industrialio-configfs.c > >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. > >> +MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com>"); >> +MODULE_DESCRIPTION("Industrial I/O configfs support"); > > You probably want > MODULE_LICENSE("GPL v2"); > > here too. Because now, at module load time, the license will default to > "unspecified" which will taint the kernel.
:), correct! I forgot about it.
Daniel.
| |