lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is not chained
Date


> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Tuesday, March 24, 2015 1:56 AM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; jbottomley@parallels.com;
> hch@infradead.org; linux-scsi@vger.kernel.org; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com
> Subject: Re: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is not
> chained
>
> On Mon, Mar 23, K. Y. Srinivasan wrote:
>
> > @@ -653,32 +640,39 @@ static unsigned int
> copy_from_bounce_buffer(struct scatterlist *orig_sgl,
> > unsigned long bounce_addr = 0;
> > unsigned long dest_addr = 0;
> > unsigned long flags;
> > + struct scatterlist *cur_dest_sgl;
> > + struct scatterlist *cur_src_sgl;
> >
> > local_irq_save(flags);
> > -
> > + cur_dest_sgl = orig_sgl;
> > + cur_src_sgl = bounce_sgl;
> > for (i = 0; i < orig_sgl_count; i++) {
> > - dest_addr = sg_kmap_atomic(orig_sgl,i) + orig_sgl[i].offset;
> > + dest_addr = (unsigned long)
> > + kmap_atomic(sg_page(cur_dest_sgl)) +
> > + cur_dest_sgl->offset;
> > dest = dest_addr;
> > destlen = orig_sgl[i].length;
> > + destlen = cur_dest_sgl->length;
>
> Double assignment.

Thanks Olaf; I will fix this and resubmit.

K. Y

>
> Olaf
\
 
 \ /
  Last update: 2015-03-24 17:41    [W:0.057 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site