Messages in this thread Patch in this message | | | Date | Tue, 24 Mar 2015 09:57:55 -0400 | From | Steven Rostedt <> | Subject | [PATCH 7/9] tools lib traceevent kbuffer: Remove extra update to data pointer in PADDING |
| |
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
When a event PADDING is hit (a deleted event that is still in the ring buffer), translate_data() sets the length of the padding and also updates the data pointer which is passed back to the caller. This is unneeded because the caller also updates the data pointer with the passed back length. translate_data() should not update the pointer, only set the length.
Cc: stable@vger.kernel.org # 3.12+ Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- tools/lib/traceevent/kbuffer-parse.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c index dcc665228c71..deb3569ab004 100644 --- a/tools/lib/traceevent/kbuffer-parse.c +++ b/tools/lib/traceevent/kbuffer-parse.c @@ -372,7 +372,6 @@ translate_data(struct kbuffer *kbuf, void *data, void **rptr, switch (type_len) { case KBUFFER_TYPE_PADDING: *length = read_4(kbuf, data); - data += *length; break; case KBUFFER_TYPE_TIME_EXTEND: -- 2.1.4
| |