Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH v3 2/4] use local dev_t instead of global | Date | Tue, 24 Mar 2015 17:36:10 +0530 |
| |
the dev_t is stored in visorchipset_platform_device.dev.devt, so we can pass that value as an argument to visorchipset_file_cleanup() instead of using the global variable in file.c
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> ---
v3: broke the previous patch in this series
drivers/staging/unisys/visorchipset/file.c | 3 +-- drivers/staging/unisys/visorchipset/file.h | 2 +- drivers/staging/unisys/visorchipset/visorchipset_main.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c index cbed1ba2..d62908d 100644 --- a/drivers/staging/unisys/visorchipset/file.c +++ b/drivers/staging/unisys/visorchipset/file.c @@ -76,13 +76,12 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel) } void -visorchipset_file_cleanup(void) +visorchipset_file_cleanup(dev_t majordev) { if (file_cdev.ops != NULL) cdev_del(&file_cdev); file_cdev.ops = NULL; unregister_chrdev_region(majordev, 1); - majordev = MKDEV(0, 0); registered = FALSE; } diff --git a/drivers/staging/unisys/visorchipset/file.h b/drivers/staging/unisys/visorchipset/file.h index dc7a195..b32a472 100644 --- a/drivers/staging/unisys/visorchipset/file.h +++ b/drivers/staging/unisys/visorchipset/file.h @@ -22,6 +22,6 @@ int visorchipset_file_init(dev_t majorDev, struct visorchannel **pControlVm_channel); -void visorchipset_file_cleanup(void); +void visorchipset_file_cleanup(dev_t majordev); #endif diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c index 9c8605d..f2663d2c 100644 --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c @@ -2278,7 +2278,7 @@ visorchipset_exit(void) visorchannel_destroy(controlvm_channel); - visorchipset_file_cleanup(); + visorchipset_file_cleanup(visorchipset_platform_device.dev.devt); POSTCODE_LINUX_2(DRIVER_EXIT_PC, POSTCODE_SEVERITY_INFO); } -- 1.8.1.2
| |