Messages in this thread | | | Date | Tue, 24 Mar 2015 20:19:46 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 1/2] Support PCU power metrics in turbostat |
| |
On Tue, Mar 24, 2015 at 05:20:13PM -0400, Len Brown wrote: > <cc: linux-pm list> > > On Thu, Nov 13, 2014 at 6:19 PM, Andi Kleen <andi@firstfloor.org> wrote: > > From: Andi Kleen <ak@linux.intel.com> > > > > Add support for reading PCU power metrics on Sandy Bridge / Ivy Bridge EP > > and Haswell Server in turbostat. This is done using the perf ABI, > > using the perf uncore driver. This requires the kernel to > > have uncore perf driver support. > > What happens if kernel doesn't include that support?
The data is not displayed.
> > The user has to specify the event group using a new -x option. All > > more sensible option characters were already taken. When -x is > > not specified no behavior changes. > > I'm concerned that turbostat cmdline is getting too complicated, > and this makes that more the case.
Modern computers are complicated. No way around it.
> > However this currently runs into a problem with the uncore > > driver that only makes us able to monitor a single band. > > Disabled until this is fixed.
BTW this is fixed. Will update. > > Custom user metrics would be also possible. > > > > The event resolution code is derived from the jevents library > > (parts of pmu-tools, http://github.com/andikleen/pmu-tools) > > and is BSD licensed. > > can we put BSD licensed code into utilities that are in the linux > kernel git tree?
I think so. There are already some.
-Andi
| |