Messages in this thread | | | Date | Tue, 24 Mar 2015 11:41:02 +0800 | From | Yijing Wang <> | Subject | Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? |
| |
On 2015/3/24 10:29, Bjorn Helgaas wrote: > On Mon, Mar 23, 2015 at 8:15 PM, Yijing Wang <wangyijing@huawei.com> wrote: >>>> sparse warnings: (new ones prefixed by >>) >>>> >>>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? >>>> >>>> Please review and possibly fold the followup patch. >>> >>> It does look like pci_find_host_bridge() is only used inside >>> drivers/pci/host-bridge.c and could be static. Given that it's only >>> used there, it doesn't even need to be renamed, so maybe you could >>> even just drop the rename patch, too. >> >> OK. >> >> Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes. >> So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes >> first, and I will refresh and fix the details soon. > > I just put them on a branch for build testing. I will review them > more closely when the build problems are resolved. > > FYI, I'll be on vacation from Mar 25 - Apr 2, so I won't be able to do > much then.
OK, I post out the new v8 version which fixed the build problems and drop the unnecessary patch.
Happy vacation!
Thanks! Yijing.
> > Bjorn > >
-- Thanks! Yijing
| |