lkml.org 
[lkml]   [2015]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue
From
Date
On Mon, 2015-03-23 at 22:37 +0200, Andrei Maresu wrote:
> The following chaeckpatch error was fixed:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
[]
> @@ -53,7 +53,7 @@
>
> #define AT_DMA_CHER 0x28 /* Channel Handler Enable Register */
> #define AT_DMA_ENA(x) (0x1 << (x))
> -#define AT_DMA_SUSP(x) (0x1 << ( 8 + (x)))
> +#define AT_DMA_SUSP(x) (0x1 << (8 + (x)))
> #define AT_DMA_KEEP(x) (0x1 << (24 + (x)))

Meh.

I think this isn't much of an improvement.
This was likely done to align these AT_ defines.

Another option might be to use the BIT macro.

#define AT_DMA_SUSP(x) BIT((x) + 8)
#define AT_DMA_KEEP(x) BIT((x) + 24)




\
 
 \ /
  Last update: 2015-03-23 22:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog