Messages in this thread Patch in this message | | | From | Petr Kulhavy <> | Subject | [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback | Date | Mon, 23 Mar 2015 21:35:01 +0100 |
| |
The "data" parameter passed indirectly to the edma_callback() should be edma_chan and not the dma_chan.
This bug was so far harmless since the offset of struct dma_chan within struct edma_chan is 0. However as soon as someone changes struct edma_chan this would cause troubles.
Signed-off-by: Petr Kulhavy <petr@barix.com> --- drivers/dma/edma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 1465610..4c8208b 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -813,7 +813,7 @@ static int edma_alloc_chan_resources(struct dma_chan *chan) LIST_HEAD(descs); a_ch_num = edma_alloc_channel(echan->ch_num, edma_callback, - chan, EVENTQ_DEFAULT); + echan, EVENTQ_DEFAULT); if (a_ch_num < 0) { ret = -ENODEV; -- 1.9.1
| |