lkml.org 
[lkml]   [2015]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86: stop using PER_CPU_VAR(kernel_stack)
On Sat, 21 Mar 2015 21:44:37 +0100
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> Instead of PER_CPU_VAR(kernel_stack), 64-bit code
> can use PER_CPU_VAR(cpu_tss + TSS_sp0).

The change log here is lacking an answer to "why". It only states what
it does. What's wrong with using kernel_stack? The change log should
explicitly state that. I have no idea why this patch is needed.

-- Steve

>
> 32-bit code switches to PER_CPU_VAR(cpu_current_top_of_stack),
> which has the same value.
>



\
 
 \ /
  Last update: 2015-03-23 15:21    [W:0.125 / U:1.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site