Messages in this thread | | | Date | Mon, 23 Mar 2015 11:08:38 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/5] perf kmem: Print big numbers using thousands' group |
| |
Em Mon, Mar 23, 2015 at 03:30:40PM +0900, Namhyung Kim escreveu: > Like perf stat, this makes easy to read the numbers on stat like below: > > # perf kmem stat > > SUMMARY > ======= > Total bytes requested: 9,770,900 > Total bytes allocated: 9,782,712 > Total bytes wasted on internal fragmentation: 11,812 > Internal fragmentation: 0.120744% > Cross CPU allocations: 74/152,819 > > Suggested-by: Ingo Molnar <mingo@kernel.org> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > static void print_result(struct perf_session *session) > @@ -706,6 +707,8 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused) > symbol__init(&session->header.env); > > if (!strcmp(argv[0], "stat")) { > + setlocale(LC_ALL, ""); > +
Applying, but I think it is better to have this call in perf's main() routine, to avoid repeating it in each tool, as 'builtin-stat' already does this, but as this affects all tools, some further testing is needed, I think, or does anyone see any problem with that?
- Arnaldo
| |