lkml.org 
[lkml]   [2015]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectalways assign miscdevice to file->private_data
Date
I've been trying this a few months ago, ( https://lkml.org/lkml/2014/10/8/98 )
in a very bad attempt that (thankfully) failed.

I'm happy to see you trying this now and got the change in drivers/fuse
merged now. I've been running a kernel with this change for quite some time,
it's obviously fine.

I also only found the btrfs ioctl miscdevice as a main user that
has to change, and the lguest driver (I sent off the lguest patch to check
if this is correct.)

I append the additional changes I have applied locally (to the fuse change)
for you. Feel free to use, test, use my signed-off-by (if you have exactly
these changes) or send them off, however you want. Please be careful and
double check to have all necessary changes merged before doing the change
in misc_open().

Also, try to find drivers that assign or use struct miscdevice themselves.
Those can be simplified. And of course drivers that basically do nothing
in open(), just to have the link in private_data.

Thanks for the work!



\
 
 \ /
  Last update: 2015-03-23 14:41    [W:0.130 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site