lkml.org 
[lkml]   [2015]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/2] extcon: max77843: fix an error code in max77843_init_muic_regmap()
Hi Dan,

On 03/15/2015 07:56 PM, Dan Carpenter wrote:
> "max77843->i2c_muic" is NULL, not an error code. Let's return -ENODEV
> here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index a3f80ca..6f0ed5a 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -715,7 +715,7 @@ static int max77843_init_muic_regmap(struct max77843 *max77843)
> if (!max77843->i2c_muic) {
> dev_err(&max77843->i2c->dev,
> "Cannot allocate I2C device for MUIC\n");
> - return PTR_ERR(max77843->i2c_muic);
> + return -ENODEV;

I think that -ENOMEM is more proper error than -ENODEV.
So, I'll use -ENOMEM value and applied it on extcon-next branch.

Thanks,
Chanwoo Choi


> }
>
> i2c_set_clientdata(max77843->i2c_muic, max77843);
>



\
 
 \ /
  Last update: 2015-03-23 03:01    [W:0.042 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site