lkml.org 
[lkml]   [2015]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support
From
From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 22 Mar 2015 21:06:00 +0100

> Hi Guenter
>
>> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd)
>> +{
>> + int ret;
>> +
>> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid);
>> + if (ret < 0)
>> + return ret;
>
> Please could you check this. I think register 0x01 here is wrong. I
> think you want 0x0b, the ATU Operations register?

Just want to mention that register mnenomics would have made this
bug more obvious :-)


\
 
 \ /
  Last update: 2015-03-22 23:41    [W:0.080 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site