Messages in this thread | | | Date | Sun, 22 Mar 2015 18:24:07 -0400 (EDT) | Subject | Re: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support | From | David Miller <> |
| |
From: Andrew Lunn <andrew@lunn.ch> Date: Sun, 22 Mar 2015 21:06:00 +0100
> Hi Guenter > >> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd) >> +{ >> + int ret; >> + >> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid); >> + if (ret < 0) >> + return ret; > > Please could you check this. I think register 0x01 here is wrong. I > think you want 0x0b, the ATU Operations register?
Just want to mention that register mnenomics would have made this bug more obvious :-)
| |