Messages in this thread |  | | Date | Sun, 22 Mar 2015 10:46:34 +0100 (CET) | | From | Fabian Frederick <> | | Subject | Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() |
| |
> On 21 March 2015 at 02:15 Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote: > > > On 21.03.2015 02:01, Lino Sanfilippo wrote: > > >> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)? > >> > > > > No, the current logic should be correct, since we want events for > > directories if we have FS_ISDIR set in the marks mask but not in its > > ignored_mask. > > > > Actually this should be: "... since we ONLY want events for directories > if we have FS_ISDIR set in the marks mask but not in its ignored_mask". > > With Fabians Code we could even get events for dirs although FAN_ONDIR > has not been set - which is not what we want. > Let's hope it only breaks ltp tests and no _real_ userland stuff (search systems ...)
Regards, Fabian
|  |