lkml.org 
[lkml]   [2015]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/18] net: dsa: mv88e6xxx: Add Hardware bridging support
Hi Guenter

> +static int _mv88e6xxx_atu_cmd(struct dsa_switch *ds, int fid, u16 cmd)
> +{
> + int ret;
> +
> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x01, fid);
> + if (ret < 0)
> + return ret;

Please could you check this. I think register 0x01 here is wrong. I
think you want 0x0b, the ATU Operations register?

Thanks
Andrew

> +
> + ret = _mv88e6xxx_reg_write(ds, REG_GLOBAL, 0x0b, cmd);
> + if (ret < 0)
> + return ret;
> +
> + return _mv88e6xxx_atu_wait(ds);
> +}
> +


\
 
 \ /
  Last update: 2015-03-22 21:21    [W:0.141 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site